Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing envoy config template to generate issuer and jwks_uri correctly #119

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

rockspore
Copy link
Contributor

#108 was not properly fixed.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #119 (efd1d0b) into master (b21c531) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   79.00%   79.00%           
=======================================
  Files          16       16           
  Lines        1867     1867           
=======================================
  Hits         1475     1475           
  Misses        209      209           
  Partials      183      183           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21c531...efd1d0b. Read the comment docs.

@rockspore rockspore marked this pull request as draft November 23, 2020 21:37
@rockspore rockspore marked this pull request as ready for review November 23, 2020 22:21
@theganyo theganyo merged commit 85723a3 into master Nov 23, 2020
@theganyo theganyo deleted the issue-108 branch November 23, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants