Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 12-13 #14

Merged
merged 13 commits into from
Jul 16, 2020
Merged

Issue 12-13 #14

merged 13 commits into from
Jul 16, 2020

Conversation

rockspore
Copy link
Contributor

fixed #12
fixed #13

oops, the branch name is incorrect.

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #14 into master will increase coverage by 4.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   70.49%   75.28%   +4.79%     
==========================================
  Files           6        6              
  Lines         959      963       +4     
==========================================
+ Hits          676      725      +49     
+ Misses        158      126      -32     
+ Partials      125      112      -13     
Impacted Files Coverage Δ
cmd/token/token.go 82.69% <100.00%> (+9.66%) ⬆️
cmd/bindings/bindings.go 83.52% <0.00%> (+7.38%) ⬆️
cmd/provision/proxy.go 63.15% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368f1a5...038e468. Read the comment docs.

@rockspore rockspore requested a review from theganyo July 16, 2020 20:57
@theganyo theganyo merged commit 1c90b0f into master Jul 16, 2020
@theganyo theganyo deleted the issue-13-14 branch July 16, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants