Unit tests #15
Merged
Unit tests #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 75.28% 80.00% +4.71%
==========================================
Files 6 6
Lines 963 955 -8
==========================================
+ Hits 725 764 +39
+ Misses 126 101 -25
+ Partials 112 90 -22
Continue to review full report at Codecov.
|
theganyo
reviewed
Jul 18, 2020
cmd/provision/legacy.go
Outdated
| if resp.StatusCode > 299 { | ||
| return nil, fmt.Errorf("creating credential, status: %d", resp.StatusCode) | ||
| } | ||
| // if resp.StatusCode > 299 { |
There was a problem hiding this comment.
If we don’t need this, we should remove it.
There was a problem hiding this comment.
Sure I will remove it. ApigeeClient explicitly checks the status code and return error on non-2XX codes.
cmd/provision/legacy.go
Outdated
| res, err = client.Do(req) | ||
| if res != nil { | ||
| defer res.Body.Close() | ||
| } | ||
| } | ||
| if err != nil { | ||
| if res.StatusCode > 299 || err != nil { |
There was a problem hiding this comment.
Do we know for certain that res will not be nil?
There was a problem hiding this comment.
Good point. Will add the null check.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
The coverage will certainly change as the cli evolves. At least for now it is at 80%, ;-)