Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed runtime_version dependency #179

Merged
merged 2 commits into from
Mar 5, 2021
Merged

removed runtime_version dependency #179

merged 2 commits into from
Mar 5, 2021

Conversation

rockspore
Copy link
Contributor

This removes /products dependency on runtime_version check.

Python callout in /version was also modified to handle either v140 or 1-4-0-20200202-... format of APIGEE_DPCOLOR.

@codecov
Copy link

codecov bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #179 (0f2108b) into master (c158f67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   80.97%   80.97%           
=======================================
  Files          17       17           
  Lines        1740     1740           
=======================================
  Hits         1409     1409           
  Misses        175      175           
  Partials      156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c158f67...0f2108b. Read the comment docs.

@rockspore rockspore marked this pull request as draft March 3, 2021 22:24
@rockspore rockspore linked an issue Mar 4, 2021 that may be closed by this pull request
remove the runtime_version dependency from the /products endpoint #178
Closed
@rockspore rockspore requested a review from theganyo March 5, 2021 02:46
@rockspore rockspore marked this pull request as ready for review March 5, 2021 02:46
@theganyo
Copy link
Member

theganyo commented Mar 5, 2021

closes #178

@rockspore rockspore merged commit 5b4c79f into master Mar 5, 2021
@rockspore rockspore deleted the issue-178 branch March 5, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theganyo theganyo theganyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove the runtime_version dependency from the /products endpoint
2 participants
@rockspore @theganyo