Two jars in a bundle to support both versions of Apigee runtime #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 81.06% 81.06%
=======================================
Files 17 17
Lines 1748 1748
=======================================
Hits 1417 1417
Misses 175 175
Partials 156 156 Continue to review full report at Codecov.
|
theganyo
requested changes
Apr 28, 2021
cmd/provision/proxies/remote-service-gcp-legacy/apiproxy/remote-service.xml
Outdated
Show resolved
Hide resolved
cmd/provision/proxies/remote-service-gcp/apiproxy/resources/java/envoy-javacallout-1.1.0.jar
Outdated
Show resolved
Hide resolved
rockspore
changed the title
theganyo
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #198
If the new bundle failed to be deployed as revisionn, the fallback will not force an old bundle deployment as revisionn + 1, which avoids another round of waiting for the old revision being undeployed and deleted.There will be only one bundle containing two jars. Hopefull the support of 1.4 and 1.5 runtime will be transparent.