Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set createNew to true in AssignMessage policies used for response #35

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

rockspore
Copy link
Contributor

Fix #33

As my developing environment udpates golang automatically, the use of string(int) was changed to string(rune(int)) to avoid error in go 1.15

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #35 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   80.96%   80.91%   -0.06%     
==========================================
  Files           7        7              
  Lines        1056     1053       -3     
==========================================
- Hits          855      852       -3     
  Misses        106      106              
  Partials       95       95              
Impacted Files Coverage Δ
cmd/provision/legacy.go 73.22% <0.00%> (ø)
cmd/root.go 90.24% <ø> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77bcc16...192a622. Read the comment docs.

@rockspore rockspore requested a review from theganyo August 3, 2020 19:27
@theganyo
Copy link
Member

theganyo commented Aug 3, 2020

There are a number of places in -envoy and -cli repos that set GODEBUG. Can these now be removed?

@rockspore
Copy link
Contributor Author

There are a number of places in -envoy and -cli repos that set GODEBUG. Can these now be removed?

According to my test, the yaml file used to deploy the remote-service-envoy still won't work without this http2client=0

@theganyo
Copy link
Member

theganyo commented Aug 3, 2020

So, it sounds like this doesn't actually addresses the problem described in #33.

@rockspore rockspore marked this pull request as draft August 3, 2020 20:56
@rockspore
Copy link
Contributor Author

rockspore commented Aug 4, 2020

The gcp-managed proxies should now all work with an http2 client. The GODEBUG environment variable has been removed. The sample config in the -envoy repo needs such update as well.

Note: The version of go in go.mod is changed to 1.14.

@rockspore rockspore marked this pull request as ready for review August 4, 2020 21:16
@theganyo
Copy link
Member

theganyo commented Aug 4, 2020

ok. please update the envoy sample. and let's update the other mod files as well.

@theganyo theganyo merged commit 58d4b59 into master Aug 4, 2020
@theganyo theganyo deleted the issue-33 branch August 4, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssignMessage Response createNew true
2 participants