Switched to OAuth2 for CG SaaS #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 7 7
Lines 1140 1140
=======================================
Hits 915 915
Misses 118 118
Partials 107 107 Continue to review full report at Codecov.
|
theganyo
reviewed
Aug 20, 2020
| octetStream = "application/octet-stream" | ||
| libraryVersion = "0.1.0" | ||
| defaultBaseURL = "https://api.enterprise.apigee.com" | ||
| basicAuthHeader = "Basic ZWRnZWNsaTplZGdlY2xpc2VjcmV0" |
There was a problem hiding this comment.
This is the required hard-coded basic auth to fetch the access token. It's a centralized credential.
Ref: https://docs.apigee.com/api-platform/system-administration/management-api-tokens#get-a-new-access-token
theganyo
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EdgeClient upon construction checks the management host and fetch the OAuth token if it is CG SaaS.
Note: To pass the unit tests, I exported a function from
apigeepackage to allow modifying theOAuthURL. No product issue but open to better solutions.Fix #44