Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provision apiproduct #6

Merged
merged 6 commits into from
Jul 13, 2020
Merged

Provision apiproduct #6

merged 6 commits into from
Jul 13, 2020

Conversation

rockspore
Copy link
Contributor

Addressing #4
Some tests were also added to increase the code coverage.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #6 into master will increase coverage by 38.34%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage   34.13%   72.47%   +38.34%     
===========================================
  Files           6        6               
  Lines         917      941       +24     
===========================================
+ Hits          313      682      +369     
+ Misses        567      146      -421     
- Partials       37      113       +76     
Impacted Files Coverage Δ
cmd/provision/provision.go 78.16% <0.00%> (+55.47%) ⬆️
cmd/provision/proxy.go 56.28% <72.72%> (+56.28%) ⬆️
cmd/token/token.go 75.33% <0.00%> (+25.33%) ⬆️
cmd/provision/legacy.go 65.83% <0.00%> (+65.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b8ca7c...e8b6a4d. Read the comment docs.

@rockspore rockspore requested a review from theganyo July 13, 2020 19:20
@theganyo theganyo merged commit 3e16624 into master Jul 13, 2020
@theganyo theganyo deleted the provision-apiproduct branch July 13, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants