Added analytics service account support #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theganyo
reviewed
Sep 1, 2020
go.mod
Outdated
|
|
||
| // replace github.com/apigee/apigee-remote-service-envoy => ../apigee-remote-service-envoy | ||
| //replace github.com/apigee/apigee-remote-service-envoy => ../apigee-remote-service-envoy |
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 79.87% 80.33% +0.45%
==========================================
Files 8 8
Lines 1277 1322 +45
==========================================
+ Hits 1020 1062 +42
- Misses 134 136 +2
- Partials 123 124 +1
Continue to review full report at Codecov.
|
theganyo
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to apigee/apigee-remote-service-envoy#42
Now the provision command optionally takes a
--service-accountflag (specific to udca service account with role Apigee Analytics Agent) which is the path to the service account json file.A new k8s Secret will be created with this service account credentials encoded. It will enable the adapter to directly upload analytics to UAP instead of the fluentd endpoint.
The dependency may need to be updated for the GitHub action to succeed. The -golib and then -envoy PRs will need to be merged first.