Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially supporting OAuth or SAML token for any Apigee type #66

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

rockspore
Copy link
Contributor

If --token/-t is specified, any other credentials such as --username/-u or --password/-p will be ignored. It's verified to work this way on CG SaaS.

Close #64

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   79.63%   79.63%           
=======================================
  Files           8        8           
  Lines        1301     1301           
=======================================
  Hits         1036     1036           
  Misses        139      139           
  Partials      126      126           
Impacted Files Coverage Δ
cmd/bindings/bindings.go 79.10% <100.00%> (ø)
cmd/provision/provision.go 82.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed88c6...32f9d26. Read the comment docs.

Copy link
Member

@theganyo theganyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to get some test coverage of this kind of thing before too long.

@theganyo theganyo merged commit 6919656 into master Sep 2, 2020
@theganyo theganyo deleted the issue-64 branch September 2, 2020 22:17
@rockspore
Copy link
Contributor Author

We'll need to get some test coverage of this kind of thing before too long.

100% agreed. I will start working on #50 that is related to this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token support for cases such as SAML users on CG SaaS
2 participants