Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples create supports analytics sa #71

Merged
merged 3 commits into from
Sep 17, 2020
Merged

samples create supports analytics sa #71

merged 3 commits into from
Sep 17, 2020

Conversation

rockspore
Copy link
Contributor

fix #67

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #71 into master will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   79.86%   80.10%   +0.24%     
==========================================
  Files          16       16              
  Lines        2001     2006       +5     
==========================================
+ Hits         1598     1607       +9     
+ Misses        212      210       -2     
+ Partials      191      189       -2     
Impacted Files Coverage Δ
cmd/samples/samples.go 83.87% <100.00%> (+4.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c85f1...bab6c5b. Read the comment docs.

cmd/samples/samples.go Show resolved Hide resolved
cmd/samples/samples_test.go Outdated Show resolved Hide resolved
@theganyo theganyo merged commit 9d5467f into master Sep 17, 2020
@theganyo theganyo deleted the issue-67 branch September 17, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update configuration templates to support analytics service account
2 participants