Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product.GetBoundTargets() returns empty array instead of null #87

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

theganyo
Copy link
Member

closes #86

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #87 into master will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   78.73%   78.51%   -0.22%     
==========================================
  Files          16       16              
  Lines        1843     1843              
==========================================
- Hits         1451     1447       -4     
- Misses        206      208       +2     
- Partials      186      188       +2     
Impacted Files Coverage Δ
cmd/bindings/bindings.go 74.46% <100.00%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0668b0a...0a2cc8d. Read the comment docs.

Copy link
Contributor

@rockspore rockspore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to point that because len(nil) behaves as if an empty array is passed in, len instead of nil-check should almost always be used to avoid surprises.

@rockspore rockspore merged commit 3fb6db8 into master Oct 20, 2020
@rockspore rockspore deleted the issue-86 branch October 20, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

product.GetBoundTargets() no longer returns null
2 participants