log internal error (#104)

* log internal error * fix typo
apigee · Oct 20, 2021 · be663b8 · be663b8
1 parent 65bc176
commit be663b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/auth/auth.go b/auth/auth.go
@@ -141,7 +141,9 @@ func (m *manager) Authenticate(ctx context.Context, apiKey string,
 		authAttempted = true
 	}
 
+	var internalError error
 	if authenticationError != nil && authenticationError != ErrBadAuth {
+		internalError = authenticationError
 		authenticationError = ErrInternalError
 	}
 
@@ -158,6 +160,8 @@ func (m *manager) Authenticate(ctx context.Context, apiKey string,
 		redactedAC := util.SprintfRedacts(redacts, "%#v", authContext)
 		if authenticationError == nil {
 			log.Debugf("Authenticate success: %s", redactedAC)
+		} else if authenticationError == ErrInternalError {
+			log.Debugf("Authenticate error: %s [%v]", redactedAC, internalError)
 		} else {
 			log.Debugf("Authenticate error: %s [%v]", redactedAC, authenticationError)
 		}

diff --git a/auth/key/verify_api_key.go b/auth/key/verify_api_key.go
@@ -180,6 +180,7 @@ func (kv *verifierImpl) singleFetchToken(ctx context.Context, apiKey string) (ma
 	}
 	res, err, _ := kv.herdBuster.Do(apiKey, fetch)
 	if err != nil {
+		log.Errorf("token fetching for API key failed: %v", err)
 		return nil, err
 	}