Skip to content

Commit

Permalink
update coding conventions; remove #![deny] from lib.rs
Browse files Browse the repository at this point in the history
Failing on errors should be done in CI, by setting -D warnings, say,
rather than hardcoding these rules in the crate.
  • Loading branch information
apoelstra committed Jun 15, 2023
1 parent a7b49cc commit abdd5bb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
4 changes: 2 additions & 2 deletions src/extensions/arith.rs
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ impl Expr<CovExtArgs> {
fn satisfy<Pk: MiniscriptKey + ToPublicKey>(
&self,
env: &TxEnv,
s: &Satisfier<Pk>,
s: &dyn Satisfier<Pk>,
) -> Result<(i64, Satisfaction), EvalError> {
match &self.inner {
ExprInner::Const(c) => Ok((*c, Satisfaction::empty())),
Expand Down Expand Up @@ -1007,7 +1007,7 @@ impl Arith<CovExtArgs> {
pub fn satisfy_helper<Pk: ToPublicKey>(
&self,
env: &TxEnv,
sat: &Satisfier<Pk>,
sat: &dyn Satisfier<Pk>,
) -> Result<Satisfaction, EvalError> {
let (res, sat_a, sat_b) = match &self.expr {
ArithInner::Eq(a, b) => {
Expand Down
8 changes: 0 additions & 8 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,6 @@
//!

#![cfg_attr(miniscript_bench, feature(test))]
// Coding conventions
#![allow(bare_trait_objects)]
#![deny(non_camel_case_types)]
#![deny(non_snake_case)]
#![deny(unused_mut)]
#![deny(dead_code)]
#![deny(unused_imports)]
#![deny(missing_docs)]
#![allow(clippy::manual_range_contains)] // this lint is just stupid
#![allow(clippy::type_complexity)] // clippy doesn't like how many generics we use

Expand Down

0 comments on commit abdd5bb

Please sign in to comment.