This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
minreq_http: re-export minreq dependency #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'd be a bit more idiomatic to add a to src/lib.rs. You can see how this is already done for base64. |
darosior
force-pushed
the
reexport_minreq
branch
from
92b3bae
to
b91dafa
Compare
|
Done. |
|
Can you do |
So that downstream users can match against error variants.
darosior
force-pushed
the
reexport_minreq
branch
from
b91dafa
to
6a5a578
Compare
|
Sure, done. |
apoelstra
approved these changes
Jun 28, 2023
This was referenced Jun 29, 2023
Merged
apoelstra
added a commit
that referenced
this pull request
Jun 29, 2023
5b34d4a Bump version to 16.0 (Antoine Poinsot) 223d556 simple_http: gate FromStr usage behind 'proxy' feature (Antoine Poinsot) d57ee9d minreq_http: make Error enum #[non_exhaustive] (Antoine Poinsot) Pull request description: To make #103 and #102 available downstream. Note i've successfully tested #103 in my software (detect and retry requests to bitcoind upon hitting a transient workqueue exceeded error). Updating the Error enum for minreq_http is an API break, so bump the major version. ACKs for top commit: tcharding: ACK 5b34d4a apoelstra: ACK 5b34d4a Tree-SHA512: f19641b39da346d61cf4f4f3c1f47bf39dd81394c26f88043ae92d30124583e74f2d61b465ef42c157e6a93fc757fc6d396aeb716c7d8347a0b48bed5a9924d3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that downstream users can match against error variants.
I had to add minreq as a direct dependency to my project. Since we are using
minreq::Errorin one variant ofminreq_http::Error, better let users directly access it asminreq_http::minreq::Error?