This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Remove unnecessary unsafe code #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can initialize the `RESULTS` vector inside a mutex and remove a couple of unsafe blocks. `lazy_static` is already in use; this patch does not change the test coverage.
As we did in rust-bitcoin/rust-bitcoin#2785. rust-lang/rust#124800 has been fixed and we can update our nightly version by whitelisting all cfgs that are used.
`clone_into` is only available in Rust 1.63 and since our MSRV is Rust 1.48 just shoosh clippy
This was referenced May 31, 2024
apoelstra
approved these changes
May 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can initialize the
RESULTSvector inside a mutex and remove a couple of unsafe blocks.lazy_staticis already in use; this patch does not change the test coverage.