Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 日志封装问题 #211

Closed
snailzed opened this issue Feb 22, 2022 · 2 comments · Fixed by #217
Closed

[BUG] 日志封装问题 #211

snailzed opened this issue Feb 22, 2022 · 2 comments · Fixed by #217
Assignees
Labels

Comments

@snailzed
Copy link

请简单描述bug的场景

日志封装问题
1)https://github.com/apolloconfig/agollo/blob/master/component/log/log.go

image

应该要给改成这样吧?

image

2)调用问题
image

如何重现

再现行为的步骤:

1.跳到“…”

2.点击“…”

3.向下滚动到“…”

4.见错误

期望
请描述期望发生什么

截图
如有

Agollo 版本 :

  • Version [e.g. 22]

日志信息

其他上下文
如有

@snailzed snailzed changed the title [BUG] [BUG] 日志封装问题 Feb 22, 2022
@zouyx
Copy link
Member

zouyx commented Feb 28, 2022

感谢你的意见,如果有问题,可以提交一下 pr。调用问题中,1.确实应该是少了个 参数,2.至于为什么要打个日志,是因为怕抛出去不打日志。

zouyx added a commit that referenced this issue Mar 19, 2022
@zouyx zouyx linked a pull request Mar 19, 2022 that will close this issue
@zouyx zouyx closed this as completed in 058afd7 Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants