Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update time for change event #158

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

cloverstd
Copy link
Contributor

加上修改时间 #157

@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2021

感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。

@coveralls
Copy link

coveralls commented Jan 9, 2021

Coverage Status

Coverage increased (+0.07%) to 74.817% when pulling 5fc2869 on cloverstd:add-ts-for-change-event into e35bcef on zouyx:master.

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否能使用notificationId 会比较好,直接取出比较其大小,不需要本地新建一个时间戳。

@zouyx zouyx self-assigned this Jan 11, 2021
@cloverstd cloverstd force-pushed the add-ts-for-change-event branch from d942b47 to 7fd356a Compare January 12, 2021 13:31
@cloverstd
Copy link
Contributor Author

是否能使用notificationId 会比较好,直接取出比较其大小,不需要本地新建一个时间戳。

确实 notificationId 会比较好

@cloverstd cloverstd force-pushed the add-ts-for-change-event branch from 7fd356a to 5fc2869 Compare January 12, 2021 13:35
@zouyx zouyx linked an issue Jan 14, 2021 that may be closed by this pull request
@zouyx zouyx changed the base branch from master to develop January 14, 2021 05:52
@zouyx zouyx merged commit cb0b34f into apolloconfig:develop Jan 14, 2021
zouyx added a commit that referenced this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listen 顺序问题
3 participants