[Fix] 修复当调用 repository.go 中 GetXXXValue，类型不一致时的报错 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢您提出Pull Request，我会尽快Review。我会在1-2日内进行查看或者回复，如果遇到节假日可能会处理较慢，敬请谅解。 |
nobodyiam
reviewed
Mar 20, 2022
storage/repository.go
Outdated
| return defaultValue | ||
| } | ||
| return i | ||
| return value.(int) |
There was a problem hiding this comment.
I think if there is any error happened in type conversion, we need to log the error and return the default value?
There was a problem hiding this comment.
I think you are right :)
I had fixed it.
zouyx
changed the title
zouyx
commented
Mar 20, 2022
| @@ -195,89 +193,37 @@ func (c *internalClient) GetApolloConfigCache() agcache.CacheInterface { | |||
|
|
|||
| //GetValue 获取配置 | |||
| func (c *internalClient) GetValue(key string) string { | |||
There was a problem hiding this comment.
this method is get default namespace for compatible old version, below as also.
| @@ -49,11 +49,11 @@ func createMockApolloConfig(expireTime int) *internalClient { | |||
| //string | |||
| configs["string"] = "value" | |||
| //int | |||
| configs["int"] = "1" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.go的GetXXXValue方法到repository.go