Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持客户端标签功能 #224

Merged
merged 2 commits into from
Apr 27, 2022
Merged

支持客户端标签功能 #224

merged 2 commits into from
Apr 27, 2022

Conversation

zanderme
Copy link
Contributor

@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2022

感谢您提出Pull Request，我会尽快Review。我会在1-2日内进行查看或者回复，如果遇到节假日可能会处理较慢，敬请谅解。

nobodyiam
nobodyiam reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is it necessary to add some tests to make sure the new logic work?

zouyx
zouyx reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zanderme Thanks!
I think that is a good feature, Could you like to add a test case for this feature?

@zanderme
Copy link
Contributor Author

I have added some test cases for this feature.

@zouyx zouyx self-assigned this Apr 21, 2022
@mergify mergify bot merged commit 9c2d2ec into apolloconfig:develop Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyiam nobodyiam nobodyiam left review comments

@zouyx zouyx zouyx approved these changes

Assignees

@zouyx zouyx

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanderme @nobodyiam @zouyx