-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] fix: sdk load balance #261
Conversation
感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。 |
ci 好像没过?我重启试试。 |
应该是remote里的TestApolloConfig_SyncABC1Error测试,没有初始化server列表,setDown节点没有生效导致一直在重试。感觉在RequestRecovery里判断下server.ipMap[appConfig.GetHost()]是否为空,为空直接返回error应该就可以了,如果没问题,我就这么修改下 |
十分感谢,我感觉我看出了问题在哪。
|
我按照你说的修改了下代码,当 serverMap 为空时会直接初始化 map,把 serverHost 加到 configService 的 serverMap 中,这样做之前的单测就没问题了。 |
fix #260