-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ApolloJsonValue注解增加部分自定义功能 #49
Comments
sounds a good idea |
请问这个加强了么?我也有这么个需求 |
This issue was created on Aug 22, 2019. Is help still wanted? Can I start working on it ? @nobodyiam 👀 |
@huxleyliau Sure, thanks for your kind help! |
I think this issue should be transferred to this apollo-java repository for a PR. Could you help with the transfer like this doc? @nobodyiam |
@huxleyliau thanks for the reminder, it's transferred now. |
Sorry about that. I made a mistake and accidentally closed PR. 💔 Could you kindly reopen it, or should I submit a new PR? 😭 I don't have the authority to do that. @nobodyiam |
It's reopened. |
@huxleyliau would you please submit a new pr? I can't make the cla assistant work on the old pr.. |
Got it. I'll now submit a new PR. |
Before closing this PR, I wasn't able to create a new one. Could you please close it again? I don't have the authority to do that close this PR. 😂 |
#52 is closed. |
* feat(apollo-client): allow user set data format partition when use @ApolloJsonValue (#2540) * style(apollo-client): format code by intellij-java-google-style.xml * test(apollo-client): test @ApolloJsonValue format date * docs: update change log #49 * Modified according to CodeReview feedback * Modified CHANGES.md for pr #53 * refactor: make gson map use ConcurrentHashMap
现状:
目前ApolloJsonValue仅支持从portal读取指定配置,没有其他功能支持。在遇到下面场景时显得有些无奈:
假如在配置中有一些日期时间相关的配置,如下:
{ "beginTime": "2019-08-21 00:00:00", "endTime": "2019-09-05 00:00:00", "switch": true }
在接收对应的时间按配置时只能用String(如果直接用Date接受,会报错:Failed to parse date ["2019-08-21 00:00:00"]: Invalid time zone indicator ' '),然后在代码中进行格式化。
建议:
ApolloJsonValue增加一个 dateFormat ,ApolloJsonValueProcessor在解析式可以用指定的格式去解析
The text was updated successfully, but these errors were encountered: