refactor(apollo-client): Optimize the exception message when failing to retrieve configuration information. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to retrieve configuration information.
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
============================================
+ Coverage 68.19% 68.22% +0.03%
- Complexity 1177 1178 +1
============================================
Files 167 167
Lines 5125 5130 +5
Branches 560 560
============================================
+ Hits 3495 3500 +5
Misses 1366 1366
Partials 264 264
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nobodyiam
reviewed
Mar 16, 2023
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ExceptionUtil.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
In a k8s environment, when configuration retrieval fails due to certain issues, the current exception message is not sufficient for troubleshooting, such as the following exception:
reason: Load Apollo Config failed - appId: infra-tconfig, cluster: default, namespace: application, url: http://apollo-service-dev-apollo-configservice.apollo:8080/configs/infra-tconfig/default/application?ip=172.26.203.126 [Cause: Could not complete get operation [Cause: apollo-service-dev-apollo-configservice.apollo.]]Finally, it was found that the issue was caused by unstable DNS resolution. The updated exception message will provide this critical information, such as:
reason: Load Apollo Config failed - appId: infra-tconfig, cluster: default, namespace: application, url: http://apollo-service-dev-apollo-configservice.apollo.:8080/configs/infra-tconfig/default/application?ip=172.26.203.126 [Cause: ApolloConfigException(Could not complete get operation) [Cause: UnknownHostException(apollo-service-dev-apollo-configservice.apollo.)]]