Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-client-config-data support spring boot 3.0 #5

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Dec 5, 2022

What's the purpose of this PR

apollo-client-config-data support spring boot 3.0

Which issue(s) this PR fixes:

Fixes apolloconfig/apollo#4668

Brief changelog

Replace Log with DeferredLogFactory.
The DeferredLogFactory is only available in spring boot 2.4.3+, so this PR will drop support for spring boot 2.4.0 ~ 2.4.2

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@vdiskg vdiskg requested a review from nobodyiam December 5, 2022 02:47
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #5 (7de751f) into main (3940553) will decrease coverage by 0.04%.
The diff coverage is 41.17%.

@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
- Coverage     67.69%   67.64%   -0.05%     
+ Complexity     1162     1161       -1     
============================================
  Files           165      165              
  Lines          5107     5109       +2     
  Branches        559      559              
============================================
- Hits           3457     3456       -1     
- Misses         1380     1382       +2     
- Partials        270      271       +1     
Impacted Files Coverage Δ
...ialize/ApolloClientExtensionInitializeFactory.java 0.00% <0.00%> (ø)
...t/ApolloClientLongPollingExtensionInitializer.java 0.00% <0.00%> (ø)
...ket/ApolloClientWebsocketExtensionInitializer.java 0.00% <0.00%> (ø)
...ta/importer/ApolloConfigDataLoaderInitializer.java 0.00% <0.00%> (ø)
...o/config/data/importer/ApolloConfigDataLoader.java 17.85% <75.00%> (+3.04%) ⬆️
...ata/importer/ApolloConfigDataLocationResolver.java 41.66% <100.00%> (ø)
.../system/ApolloClientSystemPropertyInitializer.java 75.00% <100.00%> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 77.24% <0.00%> (-1.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think we need to add com.ctrip.framework.apollo.config.data.ApolloClientConfigDataAutoConfiguration to META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports, see apollo-client support spring boot 3.0 #4
  2. The DeferredLogFactory seems only valid for spring boot 2.4.0+, does that mean apollo-client-config-data doesn't support versions prior spring boot 2.4.0 anymore? Is it possible to use other means to do the defer log? e.g. com.ctrip.framework.apollo.core.utils.DeferredLoggerFactory?

@vdiskg
Copy link
Contributor Author

vdiskg commented Dec 8, 2022

  1. The DeferredLogFactory seems only valid for spring boot 2.4.0+, does that mean apollo-client-config-data doesn't support versions prior spring boot 2.4.0 anymore? Is it possible to use other means to do the defer log? e.g. com.ctrip.framework.apollo.core.utils.DeferredLoggerFactory?

the config data loader is only available in spring boot 2.4.0+ , so this PR only drop support for spring boot 2.4.0, 2.4.1, 2.4.2

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 0a7b041 into apolloconfig:main Dec 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持spring boot 3.0
2 participants