-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo-client-config-data support spring boot 3.0 #5
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
============================================
- Coverage 67.69% 67.64% -0.05%
+ Complexity 1162 1161 -1
============================================
Files 165 165
Lines 5107 5109 +2
Branches 559 559
============================================
- Hits 3457 3456 -1
- Misses 1380 1382 +2
- Partials 270 271 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think we need to add
com.ctrip.framework.apollo.config.data.ApolloClientConfigDataAutoConfiguration
toMETA-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
, see apollo-client support spring boot 3.0 #4 - The
DeferredLogFactory
seems only valid for spring boot 2.4.0+, does that mean apollo-client-config-data doesn't support versions prior spring boot 2.4.0 anymore? Is it possible to use other means to do the defer log? e.g. com.ctrip.framework.apollo.core.utils.DeferredLoggerFactory?
the config data loader is only available in spring boot 2.4.0+ , so this PR only drop support for spring boot 2.4.0, 2.4.1, 2.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
apollo-client-config-data support spring boot 3.0
Which issue(s) this PR fixes:
Fixes apolloconfig/apollo#4668
Brief changelog
Replace
Log
withDeferredLogFactory
.The
DeferredLogFactory
is only available in spring boot 2.4.3+, so this PR will drop support for spring boot 2.4.0 ~ 2.4.2Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.