Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #56 for JUnit5 integration #57

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

kimmking
Copy link
Contributor

@kimmking kimmking commented Apr 8, 2024

What's the purpose of this PR

Avoid mockserver MockApolloExtension in JUnit5 way forcely denpend on JUnit4.

Which issue(s) this PR fixes:

Fixes #56

Brief changelog

Avoid mockserver MockApolloExtension in JUnit5 way forcely denpend on JUnit4.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Summary by CodeRabbit

  • Refactor
    • Updated logger declaration for consistency in ApolloTestingServer.

Copy link
Contributor

coderabbitai bot commented Apr 8, 2024

Walkthrough

The recent update in the ApolloTestingServer.java file focuses on aligning the logger reference with the class itself, rather than an external reference. This change is pivotal for projects migrating to or already using JUnit5 by removing an indirect dependency on JUnit4, which was introduced through a logger declaration. This modification enhances consistency and supports a cleaner, more streamlined integration with JUnit5 testing environments.

Changes

File Path Change Summary
.../apollo/mockserver/ApolloTestingServer.java Updated logger declaration to use ApolloTestingServer reference.

Assessment against linked issues

Objective Addressed Explanation
Remove JUnit4 dependency for JUnit5 projects (#56)

🐇
In the realm of code, where tests and types entwine,
A small change shines, with impact so fine.
No longer bound by the chains of the past,
JUnit5 stands proud, its shadow vast.
Through the fields of Java, with leaps and bounds,
A rabbit hops, leaving behind outdated grounds.
🌟🌱🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 8, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 07ed79b and dbec2b2.
Files selected for processing (1)
  • apollo-mockserver/src/main/java/com/ctrip/framework/apollo/mockserver/ApolloTestingServer.java (1 hunks)
Additional comments not posted (1)
apollo-mockserver/src/main/java/com/ctrip/framework/apollo/mockserver/ApolloTestingServer.java (1)

47-47: Update to logger declaration aligns with the objective to remove JUnit4 dependencies for JUnit5 users.

Consider documenting this change in the project's changelog or relevant documentation to inform users.

@kimmking
Copy link
Contributor Author

kimmking commented Apr 8, 2024

/cla

@kimmking
Copy link
Contributor Author

kimmking commented Apr 8, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 1a16249 into apolloconfig:main Apr 8, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
@nobodyiam nobodyiam added this to the 2.3.0 milestone Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnit5的MockApolloExtension方式会强制引入JUnit4依赖
2 participants