Add apollo-plugin-log4j2 module to support log4j2.xml integration
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisiyong
force-pushed
the
apollo-log4j2
branch
from
5789cac to
c8e76fc
Compare
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
============================================
+ Coverage 67.80% 67.84% +0.03%
- Complexity 1164 1165 +1
============================================
Files 165 165
Lines 5109 5109
Branches 559 559
============================================
+ Hits 3464 3466 +2
+ Misses 1377 1376 -1
+ Partials 268 267 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nisiyong
force-pushed
the
apollo-log4j2
branch
from
c8e76fc to
ba3e93d
Compare
nisiyong
force-pushed
the
apollo-log4j2
branch
from
baf17a9 to
68ca735
Compare
|
It looks great! |
Anilople
reviewed
Dec 14, 2022
Anilople
reviewed
Dec 14, 2022
| # Apollo Log4j2 | ||
|
|
||
| This module could let you integrate log4j2 with apollo easily. | ||
| You could create a namespace `log42.xml`, then log4j2 will load the configuration from it. |
There was a problem hiding this comment.
Maintain the document in https://github.com/apolloconfig/apollo/tree/master/docs is better?
There was a problem hiding this comment.
Sure, the docs will be updated if this PR was approved.
Anilople
reviewed
Dec 14, 2022
...log4j2/src/main/java/com/ctrip/framework/apollo/log4j2/ApolloLog4j2ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
nisiyong
force-pushed
the
apollo-log4j2
branch
from
4af1c9f to
0985e04
Compare
nisiyong
changed the title
apollo-log4j2 module to support log4j2.xml integrationapollo-plugin-log4j2 module to support log4j2.xml integration
|
We haven't update the |
nobodyiam
reviewed
Dec 16, 2022
Co-authored-by: Jason Song <nobodyiam@gmail.com>
nobodyiam
reviewed
Dec 20, 2022
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Add
apollo-log4j2module to support log4j2.xml integration, I have extended this module for a long time, and it works well in our production practice. I think it is better to discuss this with the community.Which issue(s) this PR fixes:
Brief changelog
org.apache.logging.log4j.core.config.ConfigurationFactory, ref docs: log4j/2.x/manual/customconfiglog4j2.xmlin the classpath, whenapollo.log4j2.enabled=true, log4j2 will load the configuration from apollo.Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.