Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nicescroll #1621

Merged
merged 2 commits into from
Nov 4, 2018
Merged

Conversation

codepiano
Copy link
Contributor

变更

相关 issue: #1370

移除 jquery nicescroll 插件

由于浏览器更改了行为,在ctrl + f 时不再滚动到具有 overflow:hidden 样式的元素里面。并且 ctrl + f 不会触发浏览器事件,无法通知到 nicescroll 插件,所以导致 nicescroll 这种自定义滚动条的插件在使用 ctrl + f 进行检索的时候不会滚动。

由于 nicescroll 在 portal 中的用处并不大,可以考虑移除改组件

目前状态

生产环境已经投入使用,目前暂未发现影响 portal 功能或者使用体验的地方

@codecov-io
Copy link

codecov-io commented Oct 30, 2018

Codecov Report

Merging #1621 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1621      +/-   ##
============================================
+ Coverage     48.73%   48.74%   +<.01%     
- Complexity     1903     1904       +1     
============================================
  Files           392      392              
  Lines         11483    11483              
  Branches       1195     1195              
============================================
+ Hits           5596     5597       +1     
+ Misses         5459     5458       -1     
  Partials        428      428
Impacted Files Coverage Δ Complexity Δ
...amework/apollo/openapi/util/ConsumerAuditUtil.java 83.33% <0%> (+2.77%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19da92c...ae7cb96. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 30, 2018

Coverage Status

Coverage increased (+0.009%) to 52.469% when pulling ae7cb96 on codepiano:remove_nicescroll_plugin into 19da92c on ctripcorp:master.

@nobodyiam
Copy link
Member

Thanks! Will take a detailed look soon!

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 703398f into apolloconfig:master Nov 4, 2018
@codepiano codepiano deleted the remove_nicescroll_plugin branch November 5, 2018 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants