Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to create missing appnamespaces and private namespaces #1707

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

nobodyiam
Copy link
Member

Fixes #1469 #1484

@codecov-io
Copy link

codecov-io commented Nov 25, 2018

Codecov Report

Merging #1707 into master will decrease coverage by 0.18%.
The diff coverage is 4.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1707      +/-   ##
============================================
- Coverage     48.71%   48.53%   -0.19%     
  Complexity     1911     1911              
============================================
  Files           392      392              
  Lines         11576    11617      +41     
  Branches       1214     1219       +5     
============================================
- Hits           5639     5638       -1     
- Misses         5490     5531      +41     
- Partials        447      448       +1
Impacted Files Coverage Δ Complexity Δ
.../apollo/portal/controller/NamespaceController.java 2.24% <0%> (-1.04%) 2 <0> (ø)
...ork/apollo/portal/service/AppNamespaceService.java 71.25% <0%> (-0.91%) 20 <0> (ø)
...mework/apollo/biz/service/AppNamespaceService.java 27.77% <0%> (ø) 7 <0> (ø) ⬇️
...p/framework/apollo/portal/api/AdminServiceAPI.java 12.73% <0%> (-0.42%) 1 <0> (ø)
...mework/apollo/portal/service/NamespaceService.java 69.29% <0%> (-0.55%) 26 <0> (ø)
...dminservice/controller/AppNamespaceController.java 26.08% <18.18%> (-9.21%) 2 <0> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 76.68% <0%> (-1.23%) 27% <0%> (-1%)
...amework/apollo/openapi/util/ConsumerAuditUtil.java 83.33% <0%> (+2.77%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9655981...e4572e1. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 25, 2018

Coverage Status

Coverage decreased (-0.2%) to 52.389% when pulling e4572e1 on nobodyiam:makeup-private-namespaces into 9655981 on ctripcorp:master.

@nobodyiam nobodyiam force-pushed the makeup-private-namespaces branch from 7ed6cb8 to 0b9f73a Compare November 25, 2018 15:42
@nobodyiam nobodyiam changed the title allow users to create missing private namespaces allow users to create missing appnamespaces and private namespaces Nov 25, 2018
@nobodyiam nobodyiam force-pushed the makeup-private-namespaces branch from 0b9f73a to e4572e1 Compare November 25, 2018 15:52
@nobodyiam nobodyiam merged commit 0091b00 into apolloconfig:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants