Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden namespace's body when namespace's size bigger than 2 #1723

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Nov 29, 2018

No description provided.

@lepdou
Copy link
Contributor Author

lepdou commented Nov 29, 2018

image

@codecov-io
Copy link

codecov-io commented Nov 29, 2018

Codecov Report

Merging #1723 into master will increase coverage by 7.47%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1723      +/-   ##
===========================================
+ Coverage     48.52%     56%   +7.47%     
+ Complexity     1910    1069     -841     
===========================================
  Files           392     191     -201     
  Lines         11617    5714    -5903     
  Branches       1219     605     -614     
===========================================
- Hits           5637    3200    -2437     
+ Misses         5532    2259    -3273     
+ Partials        448     255     -193
Impacted Files Coverage Δ Complexity Δ
...ework/apollo/portal/controller/ItemController.java
...o/configservice/wrapper/DeferredResultWrapper.java
...omponent/emailbuilder/GrayPublishEmailBuilder.java
...k/apollo/portal/controller/FavoriteController.java
...apollo/portal/entity/vo/AppRolesAssignedUsers.java
...ponent/emailbuilder/NormalPublishEmailBuilder.java
.../framework/apollo/portal/entity/vo/SystemInfo.java
...rk/apollo/portal/service/NamespaceLockService.java
...k/apollo/portal/spi/ctrip/CtripUserInfoHolder.java
...llo/portal/listener/AppNamespaceDeletionEvent.java
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ead47...725dd06. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 52.389% when pulling dabe3d13f15e89975e39af5f24ba8796c46503f1 on lepdou:namespace_view into f1ead47 on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@nobodyiam nobodyiam merged commit b3e5798 into apolloconfig:master Nov 29, 2018
@dyc87112
Copy link

这个功能可以通过配置修改成不收缩么。。。

@nobodyiam
Copy link
Member

目前还不支持配置,不过这确实是一个优化点

@wuhaoyupku
Copy link

默认收缩看起来很不方便呀,加一个全部收缩、全部展开的功能并记住吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants