Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to inject customized instance via ApolloInjectorCustomizer #3602

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Allow users to inject customized instances via ApolloInjectorCustomizer

Which issue(s) this PR fixes:

Fixes #3573

Brief changelog

  1. Add ApolloInjectorCustomizer
  2. Load customized instances in DefaultInjector

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

Codecov Report

Merging #3602 (0718c18) into master (d059795) will decrease coverage by 0.03%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3602      +/-   ##
============================================
- Coverage     50.98%   50.95%   -0.04%     
- Complexity     2330     2331       +1     
============================================
  Files           448      448              
  Lines         14006    14021      +15     
  Branches       1424     1426       +2     
============================================
+ Hits           7141     7144       +3     
- Misses         6376     6389      +13     
+ Partials        489      488       -1     
Impacted Files Coverage Δ Complexity Δ
...ip/framework/apollo/internals/DefaultInjector.java 70.00% <75.00%> (+2.00%) 7.00 <6.00> (+4.00)
...amework/foundation/internals/ServiceBootstrap.java 94.44% <100.00%> (ø) 6.00 <0.00> (ø)
...work/apollo/biz/message/DatabaseMessageSender.java 50.00% <0.00%> (-14.59%) 6.00% <0.00%> (-2.00%)
...o/openapi/filter/ConsumerAuthenticationFilter.java 94.11% <0.00%> (-5.89%) 4.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d059795...0718c18. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants