Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo client to support jdk16 #3646

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Make apollo-client compatible with jdk16

Which issue(s) this PR fixes:

Fixes #3642

Brief changelog

  • upgrade guice to 5.0.1

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-commenter
Copy link

Codecov Report

Merging #3646 (a025242) into master (b0173d7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3646      +/-   ##
============================================
- Coverage     50.98%   50.95%   -0.03%     
  Complexity     2329     2329              
============================================
  Files           449      449              
  Lines         14026    14026              
  Branches       1426     1426              
============================================
- Hits           7151     7147       -4     
- Misses         6388     6392       +4     
  Partials        487      487              
Impacted Files Coverage Δ Complexity Δ
...ework/apollo/internals/RemoteConfigRepository.java 86.25% <0.00%> (-3.13%) 24.00% <0.00%> (-1.00%)
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (+1.17%) 24.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0173d7...a025242. Read the comment docs.

@nobodyiam nobodyiam merged commit de05540 into apolloconfig:master Apr 24, 2021
@nobodyiam nobodyiam deleted the apollo-client-jdk-16 branch April 24, 2021 02:08
@nobodyiam nobodyiam added this to the 1.9.0 milestone May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用JDK16启动报错
2 participants