Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: public namespace basic function #3850

Merged
merged 17 commits into from
Oct 9, 2021
Merged

Conversation

youabcd
Copy link
Contributor

@youabcd youabcd commented Jul 26, 2021

What's the purpose of this PR

Created a basic administration page for public namespaces. All public namespaces are displayed on the page and click items to jump to the actual editing page.As shown in the figure below:
image

The original left column of the page in English mode was not aligned, now it is modified to be aligned.
image

Which issue(s) this PR fixes:

Fixes #1926

Brief changelog

first commit
The function in namespaceController is called to take out and display all the public namespaces in the database.

second commit
Make simple changes to the page style.

third commit
Based on the suggestions to make changes.

@github-actions
Copy link

github-actions bot commented Jul 26, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@youabcd
Copy link
Contributor Author

youabcd commented Jul 26, 2021

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see some comments below.
BTW, would you please follow the pull request template to add more information about this PR?
It would also be great if some screenshots could be provided.

@youabcd
Copy link
Contributor Author

youabcd commented Jul 27, 2021

I have made some changes based on suggestions.

@nobodyiam
Copy link
Member

Thanks, I think this is a small milestone achieved!
BTW, I kind of like your original design about the home page by displaying these items in one table, will you keep working on this?

a

@youabcd
Copy link
Contributor Author

youabcd commented Aug 6, 2021

I have changed the grid display to a table display and also changed the left bar to a menu, as shown below:
image
image
image
image

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #3850 (fbbeb8f) into master (982a01f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3850   +/-   ##
=========================================
  Coverage     51.55%   51.55%           
  Complexity     2529     2529           
=========================================
  Files           484      484           
  Lines         14806    14806           
  Branches       1533     1533           
=========================================
  Hits           7633     7633           
  Misses         6646     6646           
  Partials        527      527           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982a01f...fbbeb8f. Read the comment docs.

@youabcd youabcd marked this pull request as ready for review August 12, 2021 13:47
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this feature in my local environment and it looks great! Keep going!

apollo-portal/src/main/resources/static/index.html Outdated Show resolved Hide resolved
apollo-portal/src/main/resources/static/i18n/en.json Outdated Show resolved Hide resolved
apollo-portal/src/main/resources/static/index.html Outdated Show resolved Hide resolved
apollo-portal/src/main/resources/static/index.html Outdated Show resolved Hide resolved
apollo-portal/src/main/resources/static/index.html Outdated Show resolved Hide resolved
apollo-portal/src/main/resources/static/index.html Outdated Show resolved Hide resolved
apollo-portal/src/main/resources/static/index.html Outdated Show resolved Hide resolved
@nobodyiam
Copy link
Member

BTW, I really like the style of your original design, is it possible to adjust the colors, layouts, search boxes to look like below?

design

@nobodyiam nobodyiam added this to the 1.10.0 milestone Aug 21, 2021
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now. Please find some comments below.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically I think it's good to go. Please solve the remaining issues and update the latest master branch. Then we could invite more people to review.

BTW, please also update the CHANGES.md.

@nobodyiam
Copy link
Member

@youabcd Looks great now, all the pending issues are resolved! Please update the CHANGES.md and I think we are good to go.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 3d0925f into apolloconfig:master Oct 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

公共Namespace需要进入具体应用后才能维护,不够直观
3 participants