-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: public namespace basic function #3850
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see some comments below.
BTW, would you please follow the pull request template to add more information about this PR?
It would also be great if some screenshots could be provided.
apollo-portal/src/main/resources/static/scripts/controller/IndexController.js
Outdated
Show resolved
Hide resolved
I have made some changes based on suggestions. |
Codecov Report
@@ Coverage Diff @@
## master #3850 +/- ##
=========================================
Coverage 51.55% 51.55%
Complexity 2529 2529
=========================================
Files 484 484
Lines 14806 14806
Branches 1533 1533
=========================================
Hits 7633 7633
Misses 6646 6646
Partials 527 527 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this feature in my local environment and it looks great! Keep going!
apollo-portal/src/main/resources/static/vendor/iconfont/iconfont.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/vendor/iconfont/iconfont.json
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/vendor/iconfont/iconfont.css
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/controller/IndexController.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now. Please find some comments below.
apollo-portal/src/main/resources/static/views/component/user-selector.html
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/controller/IndexController.js
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/controller/IndexController.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically I think it's good to go. Please solve the remaining issues and update the latest master branch. Then we could invite more people to review.
BTW, please also update the CHANGES.md.
apollo-portal/src/main/resources/static/scripts/controller/IndexController.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/controller/IndexController.js
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/resources/static/scripts/controller/IndexController.js
Outdated
Show resolved
Hide resolved
@youabcd Looks great now, all the pending issues are resolved! Please update the CHANGES.md and I think we are good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Created a basic administration page for public namespaces. All public namespaces are displayed on the page and click items to jump to the actual editing page.As shown in the figure below:
The original left column of the page in English mode was not aligned, now it is modified to be aligned.
Which issue(s) this PR fixes:
Fixes #1926
Brief changelog
first commit
The function in namespaceController is called to take out and display all the public namespaces in the database.
second commit
Make simple changes to the page style.
third commit
Based on the suggestions to make changes.