-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell变量读取应该加$符号 #3890
shell变量读取应该加$符号 #3890
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Thanks, please also update the CHANGES.md |
Codecov Report
@@ Coverage Diff @@
## master #3890 +/- ##
=========================================
Coverage 50.10% 50.10%
Complexity 2479 2479
=========================================
Files 485 485
Lines 14996 14996
Branches 1533 1533
=========================================
Hits 7514 7514
Misses 6950 6950
Partials 532 532 Continue to review full report at Codecov.
|
@nobodyiam thanks for your reminding, I have updated CHANGES.md. |
Thanks, it looks good to me. However, we are now in the middle of releasing 1.9.0, so this bugfix would go to the next version. Let's wait several days and we would create a new CHANGES.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution.
admin/config/portal 三个模块的启动脚本中查找 SERVICE_NAME-*.jar 的逻辑中,判断文件是否存在时没有正确读取 shell 变量,需要添加 $ 符号到 shell 变量左边。