Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell变量读取应该加$符号 #3890

Merged
merged 6 commits into from Aug 26, 2021
Merged

shell变量读取应该加$符号 #3890

merged 6 commits into from Aug 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2021

admin/config/portal 三个模块的启动脚本中查找 SERVICE_NAME-*.jar 的逻辑中,判断文件是否存在时没有正确读取 shell 变量,需要添加 $ 符号到 shell 变量左边。

@github-actions
Copy link

github-actions bot commented Aug 13, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ghost
Copy link
Author

ghost commented Aug 13, 2021

I have read the CLA Document and I hereby sign the CLA

@nobodyiam
Copy link
Member

Thanks, please also update the CHANGES.md

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2021

Codecov Report

Merging #3890 (818c422) into master (772d2fa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3890   +/-   ##
=========================================
  Coverage     50.10%   50.10%           
  Complexity     2479     2479           
=========================================
  Files           485      485           
  Lines         14996    14996           
  Branches       1533     1533           
=========================================
  Hits           7514     7514           
  Misses         6950     6950           
  Partials        532      532           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 772d2fa...818c422. Read the comment docs.

@ghost
Copy link
Author

ghost commented Aug 16, 2021

@nobodyiam thanks for your reminding, I have updated CHANGES.md.

@nobodyiam
Copy link
Member

Thanks, it looks good to me. However, we are now in the middle of releasing 1.9.0, so this bugfix would go to the next version. Let's wait several days and we would create a new CHANGES.md.

@nobodyiam nobodyiam added this to the 1.10.0 milestone Aug 21, 2021
Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@JaredTan95 JaredTan95 merged commit 1615dfe into apolloconfig:master Aug 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants