Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Access Key Timestamp check configurable #3908

Merged
merged 4 commits into from
Aug 29, 2021

Conversation

nisiyong
Copy link
Member

@nisiyong nisiyong commented Aug 20, 2021

What's the purpose of this PR

Make Access Key tImestamp check configurable.

Which issue(s) this PR fixes:

Fixes #3029

Brief changelog

  • add new dynamic key in BizConfig

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nisiyong nisiyong changed the title Make Access Key TImestamp check configurable. Make Access Key Timestamp check configurable. Aug 20, 2021
@nisiyong nisiyong changed the title Make Access Key Timestamp check configurable. Make Access Key Timestamp check configurable Aug 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #3908 (9b510d3) into master (9f072d8) will decrease coverage by 0.01%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3908      +/-   ##
============================================
- Coverage     50.84%   50.83%   -0.02%     
+ Complexity     2468     2467       -1     
============================================
  Files           475      475              
  Lines         14605    14608       +3     
  Branches       1523     1523              
============================================
  Hits           7426     7426              
- Misses         6649     6652       +3     
  Partials        530      530              
Impacted Files Coverage Δ
...m/ctrip/framework/apollo/biz/config/BizConfig.java 25.86% <0.00%> (-0.93%) ⬇️
.../configservice/ConfigServiceAutoConfiguration.java 93.33% <100.00%> (ø)
...nfigservice/filter/ClientAuthenticationFilter.java 91.48% <100.00%> (+0.18%) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f072d8...9b510d3. Read the comment docs.

@nobodyiam nobodyiam added this to the 1.10.0 milestone Aug 21, 2021
@nobodyiam
Copy link
Member

please also update the CHANGES.md

@nisiyong nisiyong force-pushed the accesskey-auth-config branch from 94e7cd4 to 3f91120 Compare August 27, 2021 05:56
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 2d9d3a7 into apolloconfig:master Aug 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants