Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change scrollbar css #3925

Merged
merged 6 commits into from
Oct 19, 2021
Merged

change scrollbar css #3925

merged 6 commits into from
Oct 19, 2021

Conversation

zeemood
Copy link
Contributor

@zeemood zeemood commented Aug 27, 2021

What's the purpose of this PR

Make scrollbar visible and beautiful. For the scene of hundreds config items, it seems like that a scrollbar takes me more convenience because of its high scrollview

Which issue(s) this PR fixes:

Fixes #

Brief changelog

change scrollbar css

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Aug 27, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@zeemood
Copy link
Contributor Author

zeemood commented Aug 27, 2021

I have read the CLA Document and I hereby sign the CLA

@zeemood zeemood changed the title add scrollbar css change scrollbar css Aug 27, 2021
@JaredTan95 JaredTan95 added this to the 1.10.0 milestone Aug 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2021

Codecov Report

Merging #3925 (3016abf) into master (f909b8d) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3925      +/-   ##
============================================
+ Coverage     50.81%   50.84%   +0.03%     
  Complexity     2468     2468              
============================================
  Files           475      475              
  Lines         14608    14608              
  Branches       1523     1523              
============================================
+ Hits           7423     7428       +5     
+ Misses         6655     6651       -4     
+ Partials        530      529       -1     
Impacted Files Coverage Δ
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f909b8d...3016abf. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature looks great! Would you please also update the CHANGES.md?

@lepdou lepdou merged commit f132801 into apolloconfig:master Oct 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants