-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ingress-portal.yaml #3933
Conversation
-}} means whitespace to the right should be consumed,cause error: 'apiVersion not set'. (#apiVersion annotated)
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Thanks, would you please also help to fix ingress-configservice.yaml and ingress-adminservice.yaml? |
@lijiansgit is there any update on this? |
syntax error
syntax error
updated ! |
nothing ! |
@lijiansgit please also sign the CLA and update the CHANGES.md, thanks! |
I have read the CLA Document and I hereby sign the CLA |
Codecov Report
@@ Coverage Diff @@
## master #3933 +/- ##
============================================
+ Coverage 50.75% 50.78% +0.02%
- Complexity 2465 2467 +2
============================================
Files 475 475
Lines 14608 14608
Branches 1523 1523
============================================
+ Hits 7415 7418 +3
+ Misses 6665 6664 -1
+ Partials 528 526 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
helm install error:
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: apiVersion not set
ingress-portal.yaml syntax error:
-}} means whitespace to the right should be consumed,so apiVersion annotated
Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.