Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ctrip profile dependency. #3951

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

Accelerator96
Copy link
Contributor

@Accelerator96 Accelerator96 commented Sep 6, 2021

What's the purpose of this PR

It's not completely removed in #3920 . remove ctrip profile dependency.

@Accelerator96
Copy link
Contributor Author

#3918

@codecov-commenter
Copy link

Codecov Report

Merging #3951 (46b4ffa) into master (ada6294) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3951      +/-   ##
============================================
- Coverage     50.84%   50.77%   -0.07%     
+ Complexity     2468     2466       -2     
============================================
  Files           475      475              
  Lines         14608    14608              
  Branches       1523     1523              
============================================
- Hits           7427     7417      -10     
- Misses         6651     6664      +13     
+ Partials        530      527       -3     
Impacted Files Coverage Δ
...mework/apollo/portal/component/PortalSettings.java 57.81% <0.00%> (-7.82%) ⬇️
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...ework/apollo/internals/RemoteConfigRepository.java 86.25% <0.00%> (-3.13%) ⬇️
...amework/apollo/openapi/util/ConsumerAuditUtil.java 89.18% <0.00%> (-2.71%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 54.16% <0.00%> (-1.67%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...nfigservice/service/AccessKeyServiceWithCache.java 84.69% <0.00%> (+2.04%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 89.18% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada6294...46b4ffa. Read the comment docs.

@JaredTan95 JaredTan95 added this to the 1.10.0 milestone Sep 6, 2021
@JaredTan95 JaredTan95 merged commit 64c3eb4 into apolloconfig:master Sep 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants