Fixed some code smells in apollo-portal module #2

[WillardHu]

Signed-off-by: WillardHu wei.hu@daocloud.io

What's the purpose of this PR

• Inline variable.
• Chenge deprecated method.
• Add final or static final keyword to class field.
• Set field name to uppercase for static field.
• Optimize imports.

Which issue(s) this PR fixes:

Fixes #

Brief changelog

Fixed some code smells in apollo-portal module

Follow this checklist to help us incorporate your contribution quickly and easily:

• Read the Contributing Guide before making this pull request.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit tests to verify the code.
• Run mvn clean test to make sure this pull request doesn't break anything.
• Update the CHANGES log.

[codecov-commenter]

Codecov Report

Merging #3974 (ab8ba22) into master (bbc2c73) will decrease coverage by 0.04%.
The diff coverage is 23.33%.

@@             Coverage Diff              @@
##             master    #3974      +/-   ##
============================================
- Coverage     50.81%   50.76%   -0.05%     
+ Complexity     2470     2468       -2     
============================================
  Files           475      475              
  Lines         14603    14600       -3     
  Branches       1523     1521       -2     
============================================
- Hits           7420     7412       -8     
- Misses         6658     6661       +3     
- Partials        525      527       +2     

Impacted Files	Coverage Δ
...mework/apollo/portal/controller/AppController.java	25.88% <0.00%> (-0.31%)	⬇️
...llo/portal/controller/ConfigsImportController.java	33.33% <0.00%> (-4.17%)	⬇️
.../apollo/portal/listener/ConfigPublishListener.java	20.63% <ø> (ø)
...ip/framework/apollo/portal/service/AppService.java	17.80% <0.00%> (+0.47%)	⬆️
...p/framework/apollo/portal/service/ItemService.java	47.56% <0.00%> (-0.32%)	⬇️
...lo/portal/spi/defaultimpl/DefaultEmailService.java	5.40% <ø> (ø)
...al/spi/defaultimpl/DefaultSsoHeartbeatHandler.java	20.00% <0.00%> (ø)
...o/portal/spi/ldap/FilterLdapByGroupUserSearch.java	0.00% <ø> (ø)
...mework/apollo/portal/spi/ldap/LdapUserService.java	0.00% <0.00%> (ø)
...ollo/portal/spi/oidc/OidcLocalUserServiceImpl.java	0.00% <ø> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc2c73...ab8ba22. Read the comment docs.

[WillardHu]

WillardHu force-pushed the WillardHu:fix/code-smells branch from c646861 to ab8ba22 now

Fixed and rebase master

[nobodyiam]

LGTM