Replace String.format() with newly created class OpenApiPathBuilder #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillardHu
force-pushed
the
fix/openapi-path-builder
branch
from
b2ec7f1 to
d3bafae
Compare
Codecov Report
@@ Coverage Diff @@
## master #3982 +/- ##
============================================
+ Coverage 50.76% 51.04% +0.27%
- Complexity 2468 2479 +11
============================================
Files 475 476 +1
Lines 14600 14681 +81
Branches 1521 1521
============================================
+ Hits 7412 7494 +82
+ Misses 6661 6657 -4
- Partials 527 530 +3
Continue to review full report at Codecov.
|
WillardHu
force-pushed
the
fix/openapi-path-builder
branch
from
d3bafae to
6e2d3bc
Compare
kezhenxu94
reviewed
Sep 14, 2021
...rc/main/java/com/ctrip/framework/apollo/openapi/client/exception/ApolloOpenApiException.java
Outdated
Show resolved
Hide resolved
kezhenxu94
reviewed
Sep 14, 2021
...-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java
Outdated
Show resolved
Hide resolved
WillardHu
force-pushed
the
fix/openapi-path-builder
branch
from
6e2d3bc to
85acf67
Compare
kezhenxu94
reviewed
Sep 14, 2021
...-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java
Show resolved
Hide resolved
WillardHu
force-pushed
the
fix/openapi-path-builder
branch
from
85acf67 to
744f242
Compare
kezhenxu94
previously approved these changes
Sep 14, 2021
.../src/main/java/com/ctrip/framework/apollo/openapi/client/service/AbstractOpenApiService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: WillardHu <wei.hu@daocloud.io>
WillardHu
force-pushed
the
fix/openapi-path-builder
branch
from
110aaef to
260c228
Compare
kezhenxu94
approved these changes
Sep 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: WillardHu wei.hu@daocloud.io
What's the purpose of this PR
OpenApiPathBuilderhas better readability, maintainability, and performance. Before modifyingString.format (..)will be used twice to complete url concatenation.String.format(..)uses regular expressions to assemble strings, performance is slow.Which issue(s) this PR fixes:
Fixes #
Brief changelog
Replace String.format() with newly created class OpenApiPathBuilder
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.