Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a shortcut to scroll to the top in the dashboard #4045

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

NICEXAI
Copy link
Contributor

@NICEXAI NICEXAI commented Oct 18, 2021

#4037

Final result:

backtop

@NICEXAI
Copy link
Contributor Author

NICEXAI commented Oct 18, 2021

The angular version used by dashboard is too old, are you considering using react or vue3 to refactor later?

@DiegoKrupitza
Copy link
Contributor

The angular version used by dashboard is too old, are you considering using react or vue3 to refactor later?

In #4016 we talked about upgrading the dependencies such as AngularJs,...

@DiegoKrupitza
Copy link
Contributor

LGTM

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nobodyiam nobodyiam merged commit 0bd026b into apolloconfig:master Oct 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants