Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch LinkageError for ClassLoaderUtil.isClassPresent in case class is present but is failed to load #4097

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Catch LinkageError for ClassLoaderUtil.isClassPresent in case class is present but is failed to load

Which issue(s) this PR fixes:

Fixes #4086

Brief changelog

  • Catch LinkageError and log error for ClassLoaderUtil.isClassPresent

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #4097 (e7087e0) into master (02fff62) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4097      +/-   ##
============================================
+ Coverage     52.43%   52.47%   +0.04%     
- Complexity     2610     2613       +3     
============================================
  Files           484      484              
  Lines         15203    15206       +3     
  Branches       1572     1572              
============================================
+ Hits           7971     7980       +9     
+ Misses         6676     6672       -4     
+ Partials        556      554       -2     
Impacted Files Coverage Δ
...p/framework/apollo/core/utils/ClassLoaderUtil.java 59.25% <100.00%> (+13.42%) ⬆️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+1.20%) ⬆️
...o/openapi/filter/ConsumerAuthenticationFilter.java 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fff62...e7087e0. Read the comment docs.

@Anilople Anilople merged commit 2d6d4b5 into apolloconfig:master Nov 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2021
@nobodyiam nobodyiam deleted the fix-4086 branch November 16, 2021 00:16
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassLoaderUtil 异常捕获的问题
3 participants