Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RelativeDateFormat.java #4111

Merged
merged 2 commits into from
Nov 20, 2021
Merged

Conversation

xuxiawei
Copy link
Contributor

simplify logic and improve performance

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

simplify logic and improve performance
@github-actions
Copy link

github-actions bot commented Nov 19, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@xuxiawei
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #4111 (da83dee) into master (046a13d) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4111      +/-   ##
============================================
- Coverage     52.49%   52.43%   -0.06%     
+ Complexity     2614     2611       -3     
============================================
  Files           484      484              
  Lines         15206    15206              
  Branches       1572     1572              
============================================
- Hits           7983     7974       -9     
- Misses         6671     6680       +9     
  Partials        552      552              
Impacted Files Coverage Δ
...amework/apollo/portal/util/RelativeDateFormat.java 0.00% <0.00%> (ø)
...work/apollo/biz/message/DatabaseMessageSender.java 50.00% <0.00%> (-14.59%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 046a13d...da83dee. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 334f258 into apolloconfig:master Nov 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants