Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change 'ctripcorp' to 'apolloconfig' in .yaml files #4112

Merged
merged 2 commits into from
Nov 21, 2021

Conversation

void1104
Copy link
Contributor

@void1104 void1104 commented Nov 21, 2021

What's the purpose of this PR
The git repository has been move from ctripcorp to apolloconfig, but stil some content need to change

Which issue(s) this PR fixes:
Fixes #4078

Brief changelog
change ctripcorp to apolloconfig in three .yaml files.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Nov 21, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@void1104
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #4112 (e43ab4b) into master (334f258) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4112      +/-   ##
============================================
+ Coverage     52.43%   52.49%   +0.05%     
- Complexity     2610     2613       +3     
============================================
  Files           484      484              
  Lines         15206    15206              
  Branches       1572     1572              
============================================
+ Hits           7973     7982       +9     
+ Misses         6680     6671       -9     
  Partials        553      553              
Impacted Files Coverage Δ
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+1.20%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 64.58% <0.00%> (+14.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334f258...e43ab4b. Read the comment docs.

@@ -52,8 +52,8 @@ entries:
created: "2021-06-02T23:05:43.379448+08:00"
description: A Helm chart for Apollo Portal
digest: 5586b2597ebe098a26c94273855461891041241628d85dc13e05ce661ff5e7a2
home: https://github.com/ctripcorp/apollo
icon: https://raw.githubusercontent.com/ctripcorp/apollo/master/apollo-portal/src/main/resources/static/img/logo-simple.png
home: https://github.com/apolloconfig/apollo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 4 lines not changed in this file, for example line 23 24

home: https://github.com/ctripcorp/apollo
icon: https://raw.githubusercontent.com/ctripcorp/apollo/master/apollo-portal/src/main/resources/static/img/logo-simple.png

and line 39 40

home: https://github.com/ctripcorp/apollo
icon: https://raw.githubusercontent.com/ctripcorp/apollo/master/apollo-portal/src/main/resources/static/img/logo-simple.png

Please also update those lines.

@Anilople Anilople changed the title fix yaml config file chore: change 'ctripcorp' to 'apolloconfig' in .yaml files Nov 21, 2021
Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anilople Anilople merged commit 9e19898 into apolloconfig:master Nov 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2021
@Anilople Anilople added the good first issue good first issue Good for beginners label Nov 27, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue good first issue Good for beginners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change ctripcorp to apolloconfig in .yaml files
4 participants