Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization omits unnecessary time conversion #4118

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

xuxiawei
Copy link
Contributor

optimize the step of omitting time conversion milliseconds and then turning back time

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

xuxiawei and others added 2 commits November 25, 2021 17:28
optimize the step of omitting time conversion milliseconds and then turning back time
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2021

Codecov Report

Merging #4118 (195a8ab) into master (4a20206) will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4118      +/-   ##
============================================
+ Coverage     52.52%   52.63%   +0.10%     
- Complexity     2616     2617       +1     
============================================
  Files           484      484              
  Lines         15206    15186      -20     
  Branches       1572     1572              
============================================
+ Hits           7987     7993       +6     
+ Misses         6667     6640      -27     
- Partials        552      553       +1     
Impacted Files Coverage Δ
...amework/apollo/portal/util/RelativeDateFormat.java 0.00% <0.00%> (ø)
...o/openapi/filter/ConsumerAuthenticationFilter.java 94.11% <0.00%> (-5.89%) ⬇️
...work/apollo/biz/message/DatabaseMessageSender.java 64.58% <0.00%> (+14.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a20206...195a8ab. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 75f9950 into apolloconfig:master Nov 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants