-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split helm chart into another repo #4125
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4125 +/- ##
============================================
- Coverage 52.62% 52.52% -0.10%
+ Complexity 2616 2609 -7
============================================
Files 484 484
Lines 15186 15186
Branches 1572 1572
============================================
- Hits 7991 7977 -14
- Misses 6641 6656 +15
+ Partials 554 553 -1
Continue to review full report at Codecov.
|
The url https://www.apolloconfig.com/charts currently points to the charts directory, I think we also need to copy this |
I have copied the charts directory to docs directory of apollo-helm-chart. And now the new helm repo url is https://charts.apolloconfig.com/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Split helm chart into another repo: https://github.com/apolloconfig/apollo-helm-chart
@nobodyiam We need to update the domain point to new
helm chart
? Or Merge this after newhelm chart
works.Which issue(s) this PR fixes:
Fixes ##3959
Follow this checklist to help us incorporate your contribution quickly and easily:
CHANGES
log.