Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gray publish refresh item status(#4039) #4128

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

CalebZYC
Copy link
Contributor

@CalebZYC CalebZYC commented Dec 4, 2021

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #4039

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2021

Codecov Report

Merging #4128 (3b07a79) into master (0a76c8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4128   +/-   ##
=========================================
  Coverage     52.52%   52.52%           
  Complexity     2608     2608           
=========================================
  Files           484      484           
  Lines         15186    15186           
  Branches       1572     1572           
=========================================
  Hits           7976     7976           
  Misses         6656     6656           
  Partials        554      554           
Impacted Files Coverage Δ
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a76c8b...3b07a79. Read the comment docs.

nobodyiam
nobodyiam previously approved these changes Dec 5, 2021
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nobodyiam
Copy link
Member

@CalebZYC this is a bugfix for UI, I believe it's better to update the CHANGES.md

@CalebZYC
Copy link
Contributor Author

CalebZYC commented Dec 5, 2021

@CalebZYC this is a bugfix for UI, I believe it's better to update the CHANGES.md

已更新

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 765a24e into apolloconfig:master Dec 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2021
@CalebZYC CalebZYC deleted the issue-4039 branch December 21, 2021 12:02
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

删除多个灰度配置,页面展示错误
3 participants