Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: SpringValueProcessor extract duplicate code #4137

Merged
merged 2 commits into from
Dec 9, 2021
Merged

refactor: SpringValueProcessor extract duplicate code #4137

merged 2 commits into from
Dec 9, 2021

Conversation

mghio
Copy link
Contributor

@mghio mghio commented Dec 7, 2021

What's the purpose of this PR

Refactor SpringValueProcessor extract duplicate code.

Brief changelog

Extract duplicate code in SpringValueProcessor.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 5e17275 into apolloconfig:master Dec 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants