Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support only show difference keys when compare namespace #4165

Merged

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Dec 19, 2021

What's the purpose of this PR

support only show difference keys when compare namespace

Which issue(s) this PR fixes:

Fixes #4133

Brief changelog

image

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@lepdou lepdou force-pushed the dev/lepdou/2.0.0_optimize_compare_item branch from 74348b7 to f3a9160 Compare December 19, 2021 09:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2021

Codecov Report

Merging #4165 (57fb2bc) into master (aea31ec) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4165      +/-   ##
============================================
- Coverage     52.59%   52.56%   -0.04%     
+ Complexity     2614     2613       -1     
============================================
  Files           484      484              
  Lines         15190    15190              
  Branches       1572     1572              
============================================
- Hits           7989     7984       -5     
- Misses         6643     6648       +5     
  Partials        558      558              
Impacted Files Coverage Δ
...o/openapi/filter/ConsumerAuthenticationFilter.java 94.11% <0.00%> (-5.89%) ⬇️
...ework/apollo/internals/RemoteConfigRepository.java 85.27% <0.00%> (-3.07%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea31ec...57fb2bc. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 259aa41 into apolloconfig:master Dec 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

有没有考虑把比较功能做好?
3 participants