Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show-text-modal-directive.js(#4131) #4183

Merged
merged 4 commits into from
Jan 1, 2022

Conversation

CalebZYC
Copy link
Contributor

@CalebZYC CalebZYC commented Dec 30, 2021

What's the purpose of this PR

fix #4131

case1

{ "ext1": "||390123456000555648889990|", "ext2": "====++++++++++hhhhhhhhhhhhhhh00|||", "ext3": 10000111111111111111111111111111111111111, "ext4":"||0123456789|", "ext5":"123||_+++||--", "ext6":231313, "ext7":"|@^(!)---++++123456789#***||&&&*#|" }

image

case2

[9587743934784070, 132469186976563400000000000000000000000000005, 127525757991925097]

image

case3

["|||9587743934784070||", 132469186976563450000000000000000000000, 127525757991925097,"|hhhhhh||", "|||", "|12313|999===|", "|1239088888888888888888888886||"]

image

case4

{"ext1":"||111111111111111111111111111111#*0}}|", "ext2":"|00001|||||000||"}

image

case5

{ "id": 4, "label": "MBG1011110000000000000000000000000001", "count": 1002222222222222222222222222222222200, "ext1":"|100000000000000000000000000000000|", "ext2":"||111111111111111111111111111111#}}|", "ext3":"||1111111111111111111111110000|||"}

image

case6

["MDBQ2019110400021111111110000011111111111", "||201911040002111111111000001|||",11111111111111111111111111111111111111111,"BBBBB", 999111233333333333333333333333333333, "|00||==__+////\\\\||"]

image

case7

111111112121211111111111111111111111111111111111111

image

case8

{ "id": 4, "partnerShopLabelList": "MDBQ201911040002000001", "partnerOrderUnitChangeCount": 10000 }

image

Which issue(s) this PR fixes:

Fixes #4131

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #4183 (0006229) into master (689c7f7) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4183      +/-   ##
============================================
+ Coverage     52.55%   52.62%   +0.06%     
- Complexity     2617     2622       +5     
============================================
  Files           484      484              
  Lines         15201    15201              
  Branches       1572     1572              
============================================
+ Hits           7989     7999      +10     
+ Misses         6652     6647       -5     
+ Partials        560      555       -5     
Impacted Files Coverage Δ
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+0.60%) ⬆️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...ework/apollo/internals/RemoteConfigRepository.java 88.34% <0.00%> (+3.06%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 89.18% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689c7f7...0006229. Read the comment docs.

@nobodyiam
Copy link
Member

As this is a bug fix, would you please also update the CHANGES.md?

@CalebZYC
Copy link
Contributor Author

As this is a bug fix, would you please also update the CHANGES.md?

Done

CHANGES.md Outdated Show resolved Hide resolved
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nobodyiam nobodyiam merged commit 586cc3b into apolloconfig:master Jan 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
@CalebZYC CalebZYC deleted the issue-4131 branch March 7, 2022 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show-text-modal 特殊json值显示错误
3 participants