-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix show-text-modal-directive.js(#4131) #4183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4183 +/- ##
============================================
+ Coverage 52.55% 52.62% +0.06%
- Complexity 2617 2622 +5
============================================
Files 484 484
Lines 15201 15201
Branches 1572 1572
============================================
+ Hits 7989 7999 +10
+ Misses 6652 6647 -5
+ Partials 560 555 -5
Continue to review full report at Codecov.
|
As this is a bug fix, would you please also update the CHANGES.md? |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's the purpose of this PR
fix #4131
case1
case2
case3
case4
case5
case6
case7
case8
Which issue(s) this PR fixes:
Fixes #4131
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.