-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disable apollo client cache #4199
Allow disable apollo client cache #4199
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4199 +/- ##
============================================
+ Coverage 52.59% 52.62% +0.03%
- Complexity 2620 2627 +7
============================================
Files 484 484
Lines 15192 15200 +8
Branches 1571 1571
============================================
+ Hits 7990 7999 +9
- Misses 6645 6646 +1
+ Partials 557 555 -2
Continue to review full report at Codecov.
|
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Show resolved
Hide resolved
...t/src/test/java/com/ctrip/framework/apollo/spi/DefaultConfigFactoryDisableFileCacheTest.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/spi/DefaultConfigFactory.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/apollo/core/ApolloClientSystemConsts.java
Outdated
Show resolved
Hide resolved
e704fb5
to
8df1904
Compare
...t/src/test/java/com/ctrip/framework/apollo/spi/DefaultConfigFactoryDisableFileCacheTest.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Show resolved
Hide resolved
@nobodyiam After this change, the default value is seted in private void initPropertyNamesCacheEnabled() {
propertyNamesCacheEnabled = getPropertyBoolean(ApolloClientSystemConsts.APOLLO_PROPERTY_NAMES_CACHE_ENABLE,
ApolloClientSystemConsts.APOLLO_PROPERTY_NAMES_CACHE_ENABLE_ENVIRONMENT_VARIABLES,
"false");
} If we keep the original, it might be confused for there are more than one code setting the init value. |
@nobodyiam PTAL again, thanks |
apollo-core/src/main/java/com/ctrip/framework/apollo/core/ApolloClientSystemConsts.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cd483a2
to
24d10ac
Compare
24d10ac
to
a23bca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue(s) this PR fixes:
Fixes #4181
Brief changelog
apollo.property.file.cache.enable
apollo.property.file.cache.enable
is false, useRemoteConfigRepository
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.